implement boolean logic in bitmap2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryBubelnikSoftSmile
force-pushed
the
refactor-bitmap2
branch
from
d619e5f to
205a5e4
Compare
amakhno
reviewed
Oct 25, 2024
spatial/Bitmap2.cs
Outdated
| @@ -68,6 +68,8 @@ public Bitmap2(BitArray bits, Vector2i dimensions) | |||
|
|
|||
| public AxisAlignedBox2i GridBounds => new AxisAlignedBox2i(Vector2i.Zero, Dimensions); | |||
|
|
|||
| public BitArray Bits => (BitArray)_bits.Clone(); | |||
There was a problem hiding this comment.
Минор: Может быть неочевидно для вызывающего, что сейчас произойдет копирование. я бы иначе назвал, типа BitsCopy. + можно переиспользовать в методах ниже, все равно с огромной вероятностью инлайн случится в релизной версии
amakhno
approved these changes
Oct 25, 2024
DmitryBubelnikSoftSmile
force-pushed
the
refactor-bitmap2
branch
from
205a5e4 to
a7c3b30
Compare
| @@ -68,6 +68,8 @@ public Bitmap2(BitArray bits, Vector2i dimensions) | |||
|
|
|||
| public AxisAlignedBox2i GridBounds => new AxisAlignedBox2i(Vector2i.Zero, Dimensions); | |||
|
|
|||
| public BitArray BitsCopy => (BitArray)_bits.Clone(); | |||
There was a problem hiding this comment.
property_Get воспринимается программистами как бесплатный с вычислительной точки зрения ресурс. а в данном случае за пропертёй скрывается клонирование (выделение памяти). давай оформим это в виде Метода с соответствующим названием (типа MakeBitArrayCopy())
dmitry-garshin
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implented or,xor,and and method for getting bits for bitmap2